tor s - octos - api-muncher by torshimizu · Pull Request #41 · Ada-C9/api-muncher

torshimizu · 2018-05-07T16:39:25Z

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I read the docs, tried Postman, tried things in atom, realized I didn't have what I needed, reread the docs then retried things in Postman.
Describe your API Wrapper. How did you decide on the methods you created?	I had a method to get a list of recipes and to get one recipe. I decided on two methods because of the nature of Edamam. Edamam takes a different parameter for a single recipe search, so I needed a different method to account for that.
Describe an edge case or failure case test you wrote for your API Wrapper.	If Edemam sent back a 404, I had to rescue the error. I tried my best to test for this, but it was difficult to know how to get Edamam to send an error. I also added a test for Edemam not sending back any entries.
Explain how VCR aids in testing an API.	VCR lets you save queries for indexing so that you do not use up limited requests when testing.
What is the Heroku URL of your deployed application?	https://octo-muncher.herokuapp.com/
Provide a link to the Trello board you used	https://trello.com/b/gAcjE6d6/muncher

…rapper - hoping this will resolve heroku issue also

… is used

…ches

torshimizu · 2018-05-07T18:32:16Z

If it's not too much to ask, could mine please, please be looked at later? I really didn't get to finish/polish up things and I wasn't the most comfortable submitting what I had.

Please and thank you!

CheezItMan · 2018-05-11T00:11:03Z

test/controllers/favorites_controller_test.rb

+
+      post favorites_path, params: recipe_data
+
+      must_respond_with :success


This should be a redirect as it redirects back.

CheezItMan · 2018-05-11T00:16:02Z

app/views/layouts/application.html.erb

+    <%= csrf_meta_tags %>
+  </head>
+
+  <body class='grid-y'>


Foundation xy-grid? neat

CheezItMan · 2018-05-11T00:18:04Z

test/controllers/recipes_controller_test.rb

+    end
+    # =======================
+
+    it 'must return ok for no recipes' do


Maybe also test the flash notices?

CheezItMan · 2018-05-11T00:18:15Z

test/controllers/recipes_controller_test.rb

+    end
+
+
+    it 'redirects to root when an error is received' do


This can be removed

CheezItMan · 2018-05-11T00:21:47Z

app/controllers/sessions_controller.rb

+    auth_hash = request.env['omniauth.auth']
+
+    if auth_hash['uid']
+      user = User.build_from_google(auth_hash)


CheezItMan · 2018-05-11T00:22:10Z

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and good commit messages
Comprehension questions	Check, I'm happy to look at this again if you get additional features done, but you already have the requirements.
General
Rails fundamentals (RESTful routing, use of named paths)	Your show action isn't RESTful, to follow the pattern it should be `/recipes/:id`,
Semantic HTML	Check
Errors are reported to the user	Check
API Wrapper to handle the API requests	Check
Controller testing	Check
Lib testing	Check
Search Functionality	Check
List Functionality	Check
Show individual item functionality (link to original recipe opens in new tab)	Check
Styling
Responsive layout	Check, both in search results and show page
List View shows 10 items at a time/pagination	Check
The app is styled to create an attractive user interface	Nicely done
API Features
The App attributes Edaman	Check
The VCR casettes do not contain the API key
External Resources	Check
Link to Trello Board	Check, although I don't have access
Link to deployed app on Heroku	Nicely done
Overall	Nice work on the Google OAuth. If you get the chance show it to Zheng in the Ampers as she's working on the same and did Amazon OAuth. You hit all the learning goals and some nice extras with favorites and Google OAuth. Excellent job!

torshimizu added 30 commits May 1, 2018 22:37

ran rails new

596f0b1

added .env to gitignore

8458d7a

added file for muncher wrapper

2579ba5

changed muncher wrapper to a class

1b238d9

added vcr to gemfile, added to test_helper

476432a

created a recipes controller, trying to get tests to work for wrapper

496cba6

added a recipes class that muncher api calls on

15cade3

tested lib/recipe class

77383bb

added new attributes in test and from_api for Recipe.new

cf8a7aa

added more attributes for Recipe and added defaults

45ed311

wrote test for get_one_recipe

3e674fc

added controller tests and some views

8453a6e

fixed link to show page, now can take uri from recipe.url

51e64b5

added some css, pagination, and edamam attribution

25688eb

added a class for search button

fb6c65d

removed prys

05ca316

changed config autoload to eager load to attempt to fix heroku deploy

ba237d6

attempting to require httparty instead of including it in muncherapiw…

581a0c1

…rapper - hoping this will resolve heroku issue also

went back to include httparty and eager_load

da9206a

added a test for a query with a space

d8be09c

fixed some tests

1a89fa5

added pagination things and updated tests now that the pagination gem…

1fef322

… is used

updated styles, added omniauth gems

50db323

added google omniauth, created a sessions controller

f10758c

created a user model to track users

5528394

added a UsersController, added links to login and logout

5e9e9d3

tests for sessions controller

5ead141

added tests for SessionsController

c96babe

wrote tests for User.build_from_google

a0aadfe

added a favorites model

2298fa0

torshimizu added 15 commits May 6, 2018 13:08

added a recent searches list

e597067

added favorite-user relations and tests for relations

d912d70

created a favorites controller and routes

019c0f9

added an image column to favorites, added tests for favorites controller

d48fee1

can add to favorites via link

97003f5

added validation for favorites and displays favorites and recent sear…

7536424

…ches

added more controller tests, removed unnecessary route

581a4f2

removed clear_searches

f3fb704

updated rescue from API wrapper error and updated tests for rescue

71c9f0f

removed pry

d7baf63

fixed logout link

0365a9f

added home icon and sticky navbar

05ec956

updated card and color styles

e4013f2

added root background image

e05b5f5

added more styles for root

9399d72

torshimizu added 2 commits May 8, 2018 20:42

updated photo extension

2124fd7

updated config production

55eace8

CheezItMan reviewed May 11, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tor s - octos - api-muncher#41

tor s - octos - api-muncher#41
torshimizu wants to merge 47 commits intoAda-C9:masterfrom
torshimizu:master

torshimizu commented May 7, 2018

Uh oh!

torshimizu commented May 7, 2018

Uh oh!

CheezItMan May 11, 2018

Uh oh!

CheezItMan May 11, 2018

Uh oh!

CheezItMan May 11, 2018

Uh oh!

CheezItMan May 11, 2018

Uh oh!

CheezItMan May 11, 2018

Uh oh!

CheezItMan commented May 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		post favorites_path, params: recipe_data

		must_respond_with :success

Conversation

torshimizu commented May 7, 2018

API Muncher

Comprehension Questions

Uh oh!

torshimizu commented May 7, 2018

Uh oh!

CheezItMan May 11, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 11, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 11, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 11, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 11, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan commented May 11, 2018

API Muncher

What We're Looking For

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants